Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numpy 1.24 #5581

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Support numpy 1.24 #5581

merged 3 commits into from
Jan 3, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 2, 2023

With the release of numpy 1.24, the warning for inhomogeneous shape is now a ValueError.

This fix will make Geoviews tests pass (tested locally) in combination with the changes made in holoviz/geoviews#608.

np_123

np_124

@hoxbro hoxbro mentioned this pull request Jan 2, 2023
1 task
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Merging #5581 (0b60ea1) into main (b1395fa) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #5581      +/-   ##
==========================================
- Coverage   88.22%   88.22%   -0.01%     
==========================================
  Files         302      302              
  Lines       62180    62187       +7     
==========================================
+ Hits        54860    54865       +5     
- Misses       7320     7322       +2     
Impacted Files Coverage Δ
holoviews/core/data/spatialpandas.py 87.34% <75.00%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit e2366f7 into main Jan 3, 2023
@hoxbro hoxbro deleted the support_numpy_1.24 branch January 3, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants